From: Lennart Poettering <lennart@poettering.net>
Date: Mon, 11 Dec 2017 19:30:07 +0000 (+0100)
Subject: busctl: modernize code a bit
X-Git-Tag: v236~8^2~1
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=8d3b9edc6b2a56a0efbbbdf099b45d004fa4e24f;p=thirdparty%2Fsystemd.git

busctl: modernize code a bit

I am puzzled why coccinelle is unwilling to detect these cases...
---

diff --git a/src/busctl/busctl.c b/src/busctl/busctl.c
index 81140f9d368..2e92514c4b5 100644
--- a/src/busctl/busctl.c
+++ b/src/busctl/busctl.c
@@ -956,18 +956,14 @@ static int introspect(sd_bus *bus, char **argv) {
                         if (r < 0)
                                 return bus_log_parse_error(r);
 
-                        fclose(mf);
-                        mf = NULL;
+                        mf = safe_fclose(mf);
 
                         z = set_get(members, &((Member) {
                                                 .type = "property",
                                                 .interface = m->interface,
                                                 .name = (char*) name }));
-                        if (z) {
-                                free(z->value);
-                                z->value = buf;
-                                buf = NULL;
-                        }
+                        if (z)
+                                free_and_replace(z->value, buf);
 
                         r = sd_bus_message_exit_container(reply);
                         if (r < 0)