From: Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Date: Thu, 3 Nov 2022 14:58:44 +0000 (-0700)
Subject: gh-83004: Clean up refleak in _io initialisation (GH-98840)
X-Git-Tag: v3.10.9~82
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=8d44f36a4ad856ceefb671724b48e48f65d81ee9;p=thirdparty%2FPython%2Fcpython.git

gh-83004: Clean up refleak in _io initialisation (GH-98840)

(cherry picked from commit 1208037246eeab4c5c003f1651edfefb045e6fb7)

Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
---

diff --git a/Misc/NEWS.d/next/Library/2022-11-02-05-52-36.gh-issue-83004.LBl79O.rst b/Misc/NEWS.d/next/Library/2022-11-02-05-52-36.gh-issue-83004.LBl79O.rst
new file mode 100644
index 000000000000..4de17abd0634
--- /dev/null
+++ b/Misc/NEWS.d/next/Library/2022-11-02-05-52-36.gh-issue-83004.LBl79O.rst
@@ -0,0 +1 @@
+Clean up refleak on failed module initialisation in :mod:`_io`.
diff --git a/Modules/_io/_iomodule.c b/Modules/_io/_iomodule.c
index 170dea41e8ab..9e53de59c9cf 100644
--- a/Modules/_io/_iomodule.c
+++ b/Modules/_io/_iomodule.c
@@ -718,10 +718,10 @@ PyInit__io(void)
         goto fail;
 
     /* BlockingIOError, for compatibility */
-    Py_INCREF(PyExc_BlockingIOError);
-    if (PyModule_AddObject(m, "BlockingIOError",
-                           (PyObject *) PyExc_BlockingIOError) < 0)
+    if (PyModule_AddObjectRef(m, "BlockingIOError",
+                              (PyObject *) PyExc_BlockingIOError) < 0) {
         goto fail;
+    }
 
     /* Concrete base types of the IO ABCs.
        (the ABCs themselves are declared through inheritance in io.py)