From: Lennart Poettering <lennart@poettering.net>
Date: Tue, 13 Aug 2019 12:14:47 +0000 (+0200)
Subject: pam_systemd: don't use PAM_SYSTEM_ERR for something that isn't precisely a system... 
X-Git-Tag: v244-rc1~20^2~1
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=8d46418e93a911abd55b0e995e72974ecdfce7f4;p=thirdparty%2Fsystemd.git

pam_systemd: don't use PAM_SYSTEM_ERR for something that isn't precisely a system error

It's not really clear which PAM errors to use for which conditions, but
something called PAM_SYSTEM_ERR should probably not be used when the
error is not the result of some system call failure.
---

diff --git a/src/login/pam_systemd.c b/src/login/pam_systemd.c
index 9a938c1c9b4..7884fa24796 100644
--- a/src/login/pam_systemd.c
+++ b/src/login/pam_systemd.c
@@ -660,7 +660,7 @@ _public_ PAM_EXTERN int pam_sm_open_session(
                         return PAM_SUCCESS;
                 } else {
                         pam_syslog(handle, LOG_ERR, "Failed to create session: %s", bus_error_message(&error, r));
-                        return PAM_SYSTEM_ERR;
+                        return PAM_SESSION_ERR;
                 }
         }