From: Mukund Sivaraman <muks@isc.org>
Date: Fri, 1 Jun 2012 06:10:00 +0000 (+0530)
Subject: [1704] Clarify why we update the environment in check_environment_unchanged()
X-Git-Tag: trac2351_base~226^2~60^2^2~16
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=8d55fd24318cd72d0a624304dfb7c107813e43cf;p=thirdparty%2Fkea.git

[1704] Clarify why we update the environment in check_environment_unchanged()
---

diff --git a/src/bin/bind10/tests/bind10_test.py.in b/src/bin/bind10/tests/bind10_test.py.in
index 5e5afbac75..188ba8b02f 100644
--- a/src/bin/bind10/tests/bind10_test.py.in
+++ b/src/bin/bind10/tests/bind10_test.py.in
@@ -684,6 +684,11 @@ class TestStartStopProcessesBob(unittest.TestCase):
     """
     def check_environment_unchanged(self):
         # Check whether the environment has not been changed
+
+        # First, we delete the B10_LOCKFILE_DIR_FROM_BUILD key from both
+        # environments' copies. This is because this key can be
+        # set/updated during initialization and we don't care if it
+        # changes. We only test the rest of the environment.
         cur_os_environ = copy.deepcopy(os.environ)
         if "B10_LOCKFILE_DIR_FROM_BUILD" in original_os_environ:
             original_os_environ.pop("B10_LOCKFILE_DIR_FROM_BUILD")