From: Andrew Bartlett <abartlet@samba.org>
Date: Thu, 15 Nov 2018 00:44:23 +0000 (+1300)
Subject: s4-samr: Use GUID_buf_string() in dcesrv_samr_EnumDomainGroups()
X-Git-Tag: tdb-1.3.17~716
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=8d8303b0aecb472de33f7dbd87c80e939e98034a;p=thirdparty%2Fsamba.git

s4-samr: Use GUID_buf_string() in dcesrv_samr_EnumDomainGroups()

This avoids memory allocation

Signed-off-by: Andrew Bartlett <abartlet@samba.org>

Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
---

diff --git a/source4/rpc_server/samr/dcesrv_samr.c b/source4/rpc_server/samr/dcesrv_samr.c
index 83600642784..b485b5a2b62 100644
--- a/source4/rpc_server/samr/dcesrv_samr.c
+++ b/source4/rpc_server/samr/dcesrv_samr.c
@@ -1329,8 +1329,10 @@ static NTSTATUS dcesrv_samr_EnumDomainGroups(struct dcesrv_call_state *dce_call,
 					     attrs,
 					     0);
 		if (ret == LDB_ERR_NO_SUCH_OBJECT) {
+			struct GUID_txt_buf guid_buf;
 			char *guid_str =
-			    GUID_string(mem_ctx, &cache->entries[idx]);
+				GUID_buf_string(&cache->entries[idx],
+						&guid_buf);
 			DBG_WARNING("GUID [%s] not found\n", guid_str);
 			continue;
 		} else if (ret != LDB_SUCCESS) {
@@ -1342,8 +1344,10 @@ static NTSTATUS dcesrv_samr_EnumDomainGroups(struct dcesrv_call_state *dce_call,
 						 rec->msgs[0],
 						 "objectSID");
 		if (objectsid == NULL) {
+			struct GUID_txt_buf guid_buf;
 			char *guid_str =
-			    GUID_string(mem_ctx, &cache->entries[idx]);
+				GUID_buf_string(&cache->entries[idx],
+						&guid_buf);
 			DBG_WARNING("objectSID for GUID [%s] not found\n",
 				    guid_str);
 			continue;