From: David Mulder <dmulder@suse.com>
Date: Wed, 11 Apr 2018 18:40:18 +0000 (-0600)
Subject: libgpo: gpo_copy_file() shouldn't explicitly call smb1
X-Git-Tag: ldb-1.4.0~617
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=8e25e2f3408bda87e2acffa3fc464c32173bb814;p=thirdparty%2Fsamba.git

libgpo: gpo_copy_file() shouldn't explicitly call smb1

Don't call cli_openx directly to open a file this
calls smb1 code explicitly, which fails if we did
a multi-protocol negotiate and negotiated smb2+.
Use the higher level cli_open() instead.

Signed-off-by: David Mulder <dmulder@suse.com>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
---

diff --git a/libgpo/gpo_filesync.c b/libgpo/gpo_filesync.c
index 6e3efdaf6c1..bf0bb5381fc 100644
--- a/libgpo/gpo_filesync.c
+++ b/libgpo/gpo_filesync.c
@@ -50,7 +50,7 @@ NTSTATUS gpo_copy_file(TALLOC_CTX *mem_ctx,
 	int read_size = io_bufsize;
 	off_t nread = 0;
 
-	result = cli_openx(cli, nt_path, O_RDONLY, DENY_NONE, &fnum);
+	result = cli_open(cli, nt_path, O_RDONLY, DENY_NONE, &fnum);
 	if (!NT_STATUS_IS_OK(result)) {
 		goto out;
 	}