From: Daniel Stenberg <daniel@haxx.se>
Date: Tue, 16 Aug 2022 14:29:15 +0000 (+0200)
Subject: libssh2: setting atime or mtime >32bit on 4-bytes-long systems
X-Git-Tag: curl-7_85_0~47
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=8e88e52ed06cd2f2197b5b08e3154c6be4a6d8ce;p=thirdparty%2Fcurl.git

libssh2: setting atime or mtime >32bit on 4-bytes-long systems

Since the libssh2 API uses 'long' to store the timestamp, it cannot
transfer >32bit times on Windows and 32bit architecture builds.

Avoid nasty surprises by instead not setting such time.

Spotted by Coverity

Closes #9325
---

diff --git a/lib/vssh/libssh2.c b/lib/vssh/libssh2.c
index 2026a88e5d..9fd71b4f74 100644
--- a/lib/vssh/libssh2.c
+++ b/lib/vssh/libssh2.c
@@ -1766,8 +1766,15 @@ static CURLcode ssh_statemach_act(struct Curl_easy *data, bool *block)
           sshc->actualcode = CURLE_QUOTE_ERROR;
           break;
         }
-        sshp->quote_attrs.atime = (unsigned long)date;
-        sshp->quote_attrs.flags = LIBSSH2_SFTP_ATTR_ACMODTIME;
+#if SIZEOF_TIME_T > SIZEOF_LONG
+        if(date > 0xffffffff)
+          ;
+        else
+#endif
+        {
+          sshp->quote_attrs.atime = (unsigned long)date;
+          sshp->quote_attrs.flags = LIBSSH2_SFTP_ATTR_ACMODTIME;
+        }
       }
       else if(strncasecompare(cmd, "mtime", 5)) {
         time_t date = Curl_getdate_capped(sshc->quote_path1);
@@ -1780,8 +1787,15 @@ static CURLcode ssh_statemach_act(struct Curl_easy *data, bool *block)
           sshc->actualcode = CURLE_QUOTE_ERROR;
           break;
         }
-        sshp->quote_attrs.mtime = (unsigned long)date;
-        sshp->quote_attrs.flags = LIBSSH2_SFTP_ATTR_ACMODTIME;
+#if SIZEOF_TIME_T > SIZEOF_LONG
+        if(date > 0xffffffff)
+          ;
+        else
+#endif
+        {
+          sshp->quote_attrs.mtime = (unsigned long)date;
+          sshp->quote_attrs.flags = LIBSSH2_SFTP_ATTR_ACMODTIME;
+        }
       }
 
       /* Now send the completed structure... */