From: Volker Lendecke <vl@samba.org>
Date: Fri, 22 Jul 2016 14:06:45 +0000 (+0200)
Subject: tevent: Save 140 bytes of .text in tevent_req_create
X-Git-Tag: tdb-1.3.10~179
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=8e989a1afbdb024ae9200d89f18a5b107b181a98;p=thirdparty%2Fsamba.git

tevent: Save 140 bytes of .text in tevent_req_create

This is one of or hottest code paths, I think every bit counts here.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
---

diff --git a/lib/tevent/tevent_req.c b/lib/tevent/tevent_req.c
index 2d9cc6db574..fe613cc834c 100644
--- a/lib/tevent/tevent_req.c
+++ b/lib/tevent/tevent_req.c
@@ -77,16 +77,14 @@ struct tevent_req *_tevent_req_create(TALLOC_CTX *mem_ctx,
 		.internal.trigger		= tevent_create_immediate(req)
 	};
 
-	if (!req->internal.trigger) {
-		talloc_free(req);
-		return NULL;
-	}
-
 	data = talloc_zero_size(req, data_size);
-	if (data == NULL) {
-		talloc_free(req);
-		return NULL;
-	}
+
+	/*
+	 * No need to check for req->internal.trigger!=NULL or
+	 * data!=NULL, this can't fail: talloc_pooled_object has
+	 * already allocated sufficient memory.
+	 */
+
 	talloc_set_name_const(data, type);
 
 	req->data = data;