From: Lennart Poettering <lennart@poettering.net>
Date: Tue, 13 Nov 2018 18:39:04 +0000 (+0100)
Subject: job: add comment for EAGAIN job run case
X-Git-Tag: v240~301^2~13
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=8ebd9175dba671aa5bf52130d48f0563a20b4efd;p=thirdparty%2Fsystemd.git

job: add comment for EAGAIN job run case
---

diff --git a/src/core/job.c b/src/core/job.c
index 372d5360d53..6c4bd928a78 100644
--- a/src/core/job.c
+++ b/src/core/job.c
@@ -618,7 +618,9 @@ int job_run_and_invalidate(Job *j) {
         }
 
         if (j) {
-                if (r == -EALREADY)
+                if (r == -EAGAIN)
+                        job_set_state(j, JOB_WAITING); /* Hmm, not ready after all, let's return to JOB_WAITING state */
+                else if (r == -EALREADY)
                         r = job_finish_and_invalidate(j, JOB_DONE, true, true);
                 else if (r == -EBADR)
                         r = job_finish_and_invalidate(j, JOB_SKIPPED, true, false);
@@ -632,8 +634,6 @@ int job_run_and_invalidate(Job *j) {
                         r = job_finish_and_invalidate(j, JOB_DEPENDENCY, true, false);
                 else if (r == -ESTALE)
                         r = job_finish_and_invalidate(j, JOB_ONCE, true, false);
-                else if (r == -EAGAIN)
-                        job_set_state(j, JOB_WAITING);
                 else if (r < 0)
                         r = job_finish_and_invalidate(j, JOB_FAILED, true, false);
         }