From: Stefan Metzmacher <metze@samba.org>
Date: Wed, 13 Nov 2019 10:07:31 +0000 (+0100)
Subject: s4:gensec_krb5: make use of talloc_zero() in gensec_krb5_start()
X-Git-Tag: ldb-2.1.1~109
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=8ec0e3194bf3a7b1897e24ecc8294d8324a22809;p=thirdparty%2Fsamba.git

s4:gensec_krb5: make use of talloc_zero() in gensec_krb5_start()

This is simpler and safter in case the structure gets new elements.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
---

diff --git a/source4/auth/gensec/gensec_krb5.c b/source4/auth/gensec/gensec_krb5.c
index ccb9a4f110e..4b89dfc0b44 100644
--- a/source4/auth/gensec/gensec_krb5.c
+++ b/source4/auth/gensec/gensec_krb5.c
@@ -107,17 +107,12 @@ static NTSTATUS gensec_krb5_start(struct gensec_security *gensec_security, bool
 		return NT_STATUS_INVALID_PARAMETER;
 	}
 
-	gensec_krb5_state = talloc(gensec_security, struct gensec_krb5_state);
+	gensec_krb5_state = talloc_zero(gensec_security, struct gensec_krb5_state);
 	if (!gensec_krb5_state) {
 		return NT_STATUS_NO_MEMORY;
 	}
 
 	gensec_security->private_data = gensec_krb5_state;
-	gensec_krb5_state->smb_krb5_context = NULL;
-	gensec_krb5_state->auth_context = NULL;
-	gensec_krb5_state->ticket = NULL;
-	ZERO_STRUCT(gensec_krb5_state->enc_ticket);
-	gensec_krb5_state->keyblock = NULL;
 	gensec_krb5_state->gssapi = gssapi;
 
 	talloc_set_destructor(gensec_krb5_state, gensec_krb5_destroy);