From: Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com> Date: Mon, 9 Aug 2021 17:39:05 +0000 (-0700) Subject: bpo-38840: Incorrect __all__ in multiprocessing.managers (GH-18034) X-Git-Tag: v3.10.0rc2~116 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=8ece98a7e418c3c68a4c61bc47a2d0931b59a889;p=thirdparty%2FPython%2Fcpython.git bpo-38840: Incorrect __all__ in multiprocessing.managers (GH-18034) This was causing test___all__ to fail on platforms lacking a shared memory implementation. Co-Authored-By: Xavier de Gaye Co-authored-by: Ɓukasz Langa (cherry picked from commit d0978761118856e8ca8ea7b162a6585b8da83df9) Co-authored-by: Zackery Spytz --- diff --git a/Lib/multiprocessing/managers.py b/Lib/multiprocessing/managers.py index b981b0e1cb8e..b6b4cdd9ac15 100644 --- a/Lib/multiprocessing/managers.py +++ b/Lib/multiprocessing/managers.py @@ -8,8 +8,7 @@ # Licensed to PSF under a Contributor Agreement. # -__all__ = [ 'BaseManager', 'SyncManager', 'BaseProxy', 'Token', - 'SharedMemoryManager' ] +__all__ = [ 'BaseManager', 'SyncManager', 'BaseProxy', 'Token' ] # # Imports @@ -35,9 +34,11 @@ from . import util from . import get_context try: from . import shared_memory - HAS_SHMEM = True except ImportError: HAS_SHMEM = False +else: + HAS_SHMEM = True + __all__.append('SharedMemoryManager') # # Register some things for pickling diff --git a/Misc/NEWS.d/next/Library/2020-01-16-23-41-16.bpo-38840.VzzYZz.rst b/Misc/NEWS.d/next/Library/2020-01-16-23-41-16.bpo-38840.VzzYZz.rst new file mode 100644 index 000000000000..727f62b52a71 --- /dev/null +++ b/Misc/NEWS.d/next/Library/2020-01-16-23-41-16.bpo-38840.VzzYZz.rst @@ -0,0 +1 @@ +Fix ``test___all__`` on platforms lacking a shared memory implementation.