From: Uri Simchoni Date: Sun, 19 Nov 2017 18:34:58 +0000 (+0000) Subject: smbspool_krb5_wrapper: fix some error messages X-Git-Tag: talloc-2.1.11~404 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=8efe057a8780712373b93cc1b2b55ccc8a44220d;p=thirdparty%2Fsamba.git smbspool_krb5_wrapper: fix some error messages Make cups_smb_debug declaration printf-aware to avoid picky warning about printf with variable format string. This in turn revealed some formatting errors. Signed-off-by: Uri Simchoni Reviewed-by: Andrew Bartlett --- diff --git a/source3/client/smbspool_krb5_wrapper.c b/source3/client/smbspool_krb5_wrapper.c index 9a82b2a7b69..dee3b4c54be 100644 --- a/source3/client/smbspool_krb5_wrapper.c +++ b/source3/client/smbspool_krb5_wrapper.c @@ -37,7 +37,8 @@ enum cups_smb_dbglvl_e { CUPS_SMB_LOG_DEBUG = 0, CUPS_SMB_LOG_ERROR, }; -static void cups_smb_debug(enum cups_smb_dbglvl_e lvl, const char *format, ...); +static void cups_smb_debug(enum cups_smb_dbglvl_e lvl, const char *format, ...) + PRINTF_ATTRIBUTE(2, 3); #define CUPS_SMB_DEBUG(...) cups_smb_debug(CUPS_SMB_LOG_DEBUG, __VA_ARGS__) #define CUPS_SMB_ERROR(...) cups_smb_debug(CUPS_SMB_LOG_DEBUG, __VA_ARGS__) @@ -166,7 +167,7 @@ int main(int argc, char *argv[]) CUPS_SMB_DEBUG("Switching to gid=%d", gid); rc = setgid(gid); if (rc != 0) { - CUPS_SMB_ERROR("Failed to switch to gid=%u", + CUPS_SMB_ERROR("Failed to switch to gid=%u - %s", gid, strerror(errno)); return CUPS_BACKEND_FAILED; @@ -175,7 +176,7 @@ int main(int argc, char *argv[]) CUPS_SMB_DEBUG("Switching to uid=%u", uid); rc = setuid(uid); if (rc != 0) { - CUPS_SMB_ERROR("Failed to switch to uid=%u", + CUPS_SMB_ERROR("Failed to switch to uid=%u - %s", uid, strerror(errno)); return CUPS_BACKEND_FAILED;