From: Nick Mathewson <nickm@torproject.org>
Date: Tue, 11 Nov 2008 17:14:12 +0000 (+0000)
Subject: Be even _more_ careful when signatures are bogus.
X-Git-Tag: tor-0.2.1.8-alpha~75
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=8f1952bf11561f98d2eea431ca58a17d70d951b2;p=thirdparty%2Ftor.git

Be even _more_ careful when signatures are bogus.

svn:r17252
---

diff --git a/src/or/dirvote.c b/src/or/dirvote.c
index 7dce375c73..69c5e09a1c 100644
--- a/src/or/dirvote.c
+++ b/src/or/dirvote.c
@@ -2049,7 +2049,12 @@ dirvote_add_signatures_to_pending_consensus(
       networkstatus_get_detached_signatures(pending_consensus);
     const char *src;
     char *dst, *dst_end;
-    size_t new_consensus_len =
+    size_t new_consensus_len;
+    if (!new_detached) {
+      *msg_out = "No signatures to add";
+      goto err;
+    }
+    new_consensus_len =
       strlen(pending_consensus_body) + strlen(new_detached) + 1;
     pending_consensus_body = tor_realloc(pending_consensus_body,
                                          new_consensus_len);