From: Rafael J. Wysocki Date: Wed, 12 Nov 2025 16:24:40 +0000 (+0100) Subject: cpuidle: governors: teo: Use s64 consistently in teo_update() X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=8f3f01082d7ab334706c7d96c9271cd99e68aabc;p=thirdparty%2Fkernel%2Flinux.git cpuidle: governors: teo: Use s64 consistently in teo_update() Two local variables in teo_update() are defined as u64, but their values are then compared with s64 values, so it is more consistent to use s64 as their data type. No intentional functional impact. Signed-off-by: Rafael J. Wysocki Reviewed-by: Christian Loehle Tested-by: Christian Loehle Link: https://patch.msgid.link/3026616.e9J7NaK4W3@rafael.j.wysocki --- diff --git a/drivers/cpuidle/governors/teo.c b/drivers/cpuidle/governors/teo.c index ada42e2ca7593..88ed47e868b9c 100644 --- a/drivers/cpuidle/governors/teo.c +++ b/drivers/cpuidle/governors/teo.c @@ -157,8 +157,7 @@ static void teo_update(struct cpuidle_driver *drv, struct cpuidle_device *dev) { struct teo_cpu *cpu_data = this_cpu_ptr(&teo_cpus); int i, idx_timer = 0, idx_duration = 0; - s64 target_residency_ns; - u64 measured_ns; + s64 target_residency_ns, measured_ns; cpu_data->short_idles -= cpu_data->short_idles >> DECAY_SHIFT; @@ -167,9 +166,9 @@ static void teo_update(struct cpuidle_driver *drv, struct cpuidle_device *dev) * If one of the safety nets has triggered, assume that this * might have been a long sleep. */ - measured_ns = U64_MAX; + measured_ns = S64_MAX; } else { - u64 lat_ns = drv->states[dev->last_state_idx].exit_latency_ns; + s64 lat_ns = drv->states[dev->last_state_idx].exit_latency_ns; measured_ns = dev->last_residency_ns; /*