From: Noel Power <noel.power@suse.com>
Date: Fri, 24 May 2019 13:01:30 +0000 (+0000)
Subject: lib/tevent: clang:
X-Git-Tag: ldb-2.0.5~414
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=8f422ada8c4d4efc0a9122479b4719c0086281d7;p=thirdparty%2Fsamba.git

lib/tevent: clang:

Fixes:

lib/tevent/tevent_wrapper.c:213:6: warning: Access to field 'destroyed' results in a dereference of a null pointer (loaded from variable 'glue') <--[clang]

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Gary Lockyer gary@catalyst.net.nz
---

diff --git a/lib/tevent/tevent_wrapper.c b/lib/tevent/tevent_wrapper.c
index deeb64ec177..a0e915f6753 100644
--- a/lib/tevent/tevent_wrapper.c
+++ b/lib/tevent/tevent_wrapper.c
@@ -208,6 +208,8 @@ static int tevent_wrapper_context_destructor(struct tevent_context *wrap_ev)
 	if (glue == NULL) {
 		tevent_abort(wrap_ev,
 			"tevent_wrapper_context_destructor() active on main");
+		/* static checker support, return below is never reached */
+		return -1;
 	}
 
 	if (glue->destroyed && glue->busy) {