From: Eamon Walsh <ewalsh@tycho.nsa.gov>
Date: Fri, 20 Mar 2009 04:26:42 +0000 (-0400)
Subject: dbus-launch: use InputOnly X window
X-Git-Tag: dbus-1.3.0~53
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=8f5c3e3c25901b089bc3fb87d53c7a98df48121f;p=thirdparty%2Fdbus.git

dbus-launch: use InputOnly X window

Working on SELinux policy for X, and came across this issue in dbus-launch:

Windows created for use as property/selection placeholders should be of
class InputOnly, since no drawing is ever done to them.

Signed-off-by: Eamon Walsh <ewalsh@tycho.nsa.gov>
Signed-off-by: Thiago Macieira <thiago@kde.org>
---

diff --git a/tools/dbus-launch-x11.c b/tools/dbus-launch-x11.c
index 442e9ba24..b18241814 100644
--- a/tools/dbus-launch-x11.c
+++ b/tools/dbus-launch-x11.c
@@ -361,9 +361,9 @@ set_address_in_x11(char *address, pid_t pid)
     }
 
   /* Create our window */
-  wid = XCreateSimpleWindow (xdisplay, RootWindow (xdisplay, 0), -20, -20, 10, 10,
-                             0, WhitePixel (xdisplay, 0),
-                             BlackPixel (xdisplay, 0));
+  wid = XCreateWindow (xdisplay, RootWindow (xdisplay, 0), -20, -20, 10, 10,
+                       0, CopyFromParent, InputOnly, CopyFromParent,
+                       0, NULL);
   verbose ("Created window %d\n", wid);
 
   /* Save the property in the window */