From: Michael Adam <obnox@samba.org>
Date: Mon, 30 Jan 2012 13:15:14 +0000 (+0100)
Subject: s3:net ads join: improve status evaluation for call to net_update_dns()
X-Git-Tag: tevent-0.9.15~128
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=8f9b43281d7ad425a4e6681503eb6e872d9040d7;p=thirdparty%2Fsamba.git

s3:net ads join: improve status evaluation for call to net_update_dns()

untangle assignment from check and log error code in message if failed.
---

diff --git a/source3/utils/net_ads.c b/source3/utils/net_ads.c
index ecb04ceea61..15f2b54ee99 100644
--- a/source3/utils/net_ads.c
+++ b/source3/utils/net_ads.c
@@ -1466,6 +1466,7 @@ int net_ads_join(struct net_context *c, int argc, const char **argv)
 		/* We enter this block with user creds */
 		ADS_STRUCT *ads_dns = NULL;
 		int ret;
+		NTSTATUS status;
 
 		ads_dns = ads_init(lp_realm(), NULL, r->in.dc_name);
 
@@ -1507,8 +1508,10 @@ int net_ads_join(struct net_context *c, int argc, const char **argv)
 			goto dns_done;
 		}
 
-		if (!NT_STATUS_IS_OK(net_update_dns( ctx, ads_dns, NULL))) {
-			d_fprintf( stderr, _("DNS update failed!\n"));
+		status = net_update_dns(ctx, ads_dns, NULL);
+		if (!NT_STATUS_IS_OK(status)) {
+			d_fprintf( stderr, _("DNS update failed: %s\n"),
+				  nt_errstr(status));
 		}
 
 		/* exit from this block using machine creds */