From: Jule Anger <ja@sernet.de>
Date: Wed, 26 Aug 2020 13:07:16 +0000 (+0200)
Subject: samba-tool group: add 'group create' as synonym for 'group add'
X-Git-Tag: talloc-2.3.2~348
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=90988ff69f85454307fb83564e5136bf1d33c3a6;p=thirdparty%2Fsamba.git

samba-tool group: add 'group create' as synonym for 'group add'

Add 'group create' command for a symmetric set of
samba-tool subcommands

Signed-off-by: Jule Anger <ja@sernet.de>
Reviewed-by: Björn Baumbach <bb@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
---

diff --git a/python/samba/netcmd/group.py b/python/samba/netcmd/group.py
index e41c7b45a4f..2942d553f2d 100644
--- a/python/samba/netcmd/group.py
+++ b/python/samba/netcmd/group.py
@@ -53,9 +53,9 @@ distribution_group = dict({"Domain": GTYPE_DISTRIBUTION_DOMAIN_LOCAL_GROUP,
 class cmd_group_add(Command):
     """Creates a new AD group.
 
-This command creates a new Active Directory group.  The groupname specified on the command is a unique sAMAccountName.
+This command adds a new Active Directory group.  The groupname specified on the command is a unique sAMAccountName.
 
-An Active Directory group may contain user and computer accounts as well as other groups.  An administrator creates a group and adds members to that group so they can be managed as a single entity.  This helps to simplify security and system administration.
+An Active Directory group may contain user and computer accounts as well as other groups.  An administrator adds a new group and adds members to that group so they can be managed as a single entity.  This helps to simplify security and system administration.
 
 Groups may also be used to establish email distribution lists, using --group-type=Distribution.
 
@@ -132,7 +132,7 @@ Example3 adds a new RFC2307 enabled group for NIS domain samdom and GID 12345 (b
                            gidnumber=gid_number, nisdomain=nis_domain)
         except Exception as e:
             # FIXME: catch more specific exception
-            raise CommandError('Failed to create group "%s"' % groupname, e)
+            raise CommandError('Failed to add group "%s"' % groupname, e)
         self.outf.write("Added group %s\n" % groupname)
 
 
@@ -1177,6 +1177,7 @@ class cmd_group(SuperCommand):
 
     subcommands = {}
     subcommands["add"] = cmd_group_add()
+    subcommands["create"] = cmd_group_add()
     subcommands["delete"] = cmd_group_delete()
     subcommands["edit"] = cmd_group_edit()
     subcommands["addmembers"] = cmd_group_add_members()