From: Ondřej Surý <ondrej@isc.org>
Date: Mon, 19 Dec 2022 17:17:46 +0000 (+0100)
Subject: Fix assignment vs comparison typo in tcp_connected()
X-Git-Tag: v9.19.9~66^2~2
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=90cd14f62046d9fa4b1ec0c75143be96c8c4ac78;p=thirdparty%2Fbind9.git

Fix assignment vs comparison typo in tcp_connected()

In tcp_connected() a typo has turned a DbC check into an assignment
breaking the state machine and making the dns_dispatch_gettcp() try to
attach to dispatch in process of destruction.
---

diff --git a/lib/dns/dispatch.c b/lib/dns/dispatch.c
index b5923b1ed57..655573906f9 100644
--- a/lib/dns/dispatch.c
+++ b/lib/dns/dispatch.c
@@ -1877,7 +1877,7 @@ tcp_connected(isc_nmhandle_t *handle, isc_result_t eresult, void *arg) {
 	}
 
 	LOCK(&disp->lock);
-	INSIST(disp->state = DNS_DISPATCHSTATE_CONNECTING);
+	INSIST(disp->state == DNS_DISPATCHSTATE_CONNECTING);
 
 	if (eresult == ISC_R_SUCCESS) {
 		disp->state = DNS_DISPATCHSTATE_CONNECTED;