From: Greg Hudson <ghudson@mit.edu>
Date: Fri, 21 Dec 2012 21:18:34 +0000 (-0500)
Subject: Initialize ret in process_pa_data
X-Git-Tag: krb5-1.12-alpha1~382
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=90e43628202157d72fb78bbb837795d91d5ce8da;p=thirdparty%2Fkrb5.git

Initialize ret in process_pa_data

If the for loop never consults any preauth modules and must_preauth is
false, we might never set ret, so we need to initialize it.  The bug
was introduced in 5c23bce0e8d3328bb36bc85ee10cfac486b8ae9b and is
detected by some versions of gcc with -O2.
---

diff --git a/src/lib/krb5/krb/preauth2.c b/src/lib/krb5/krb/preauth2.c
index a06233c27d..8d5439ccf4 100644
--- a/src/lib/krb5/krb/preauth2.c
+++ b/src/lib/krb5/krb/preauth2.c
@@ -586,7 +586,7 @@ process_pa_data(krb5_context context, krb5_get_init_creds_opt *opt,
     struct krb5_preauth_context_st *pctx = context->preauth_context;
     struct errinfo save = EMPTY_ERRINFO;
     krb5_pa_data *pa, **pa_ptr, **mod_pa;
-    krb5_error_code ret;
+    krb5_error_code ret = 0;
     clpreauth_handle h;
     int real, i;