From: Günther Deschner Date: Sat, 28 Oct 2017 09:10:07 +0000 (+0200) Subject: s4-torture: remove obsolete comment in libsmbclient torture suite. X-Git-Tag: tevent-0.9.34~64 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=910b0ce2a2e0d671c27a88176ed00e8995669773;p=thirdparty%2Fsamba.git s4-torture: remove obsolete comment in libsmbclient torture suite. Since smbc_setX calls now handle string allocation using malloc themselves (since commit 2d41b1ab78639abe4ae030ff482573f464564dd7) we indeed no longer need to provide malloced strings (the extra malloc already got removed earlier). Guenther Signed-off-by: Günther Deschner Reviewed-by: Andreas Schneider Autobuild-User(master): Andreas Schneider Autobuild-Date(master): Mon Oct 30 21:09:14 CET 2017 on sn-devel-144 --- diff --git a/source4/torture/libsmbclient/libsmbclient.c b/source4/torture/libsmbclient/libsmbclient.c index 16ad35182cd..a56a5de55d7 100644 --- a/source4/torture/libsmbclient/libsmbclient.c +++ b/source4/torture/libsmbclient/libsmbclient.c @@ -36,8 +36,6 @@ bool torture_libsmbclient_init_context(struct torture_context *tctx, smbc_setDebug(ctx, DEBUGLEVEL); smbc_setOptionDebugToStderr(ctx, 1); - /* yes, libsmbclient API frees the username when freeing the context, so - * have to pass malloced data here */ smbc_setUser(ctx, cli_credentials_get_username(popt_get_cmdline_credentials()));