From: Greg Kroah-Hartman Date: Wed, 26 Jun 2019 08:28:46 +0000 (+0800) Subject: 4.4-stable patches X-Git-Tag: v4.4.184~5 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=914118faf8a8ee2581fc61ac6cac3bca420ee3bf;p=thirdparty%2Fkernel%2Fstable-queue.git 4.4-stable patches added patches: tcp-refine-memory-limit-test-in-tcp_fragment.patch --- diff --git a/queue-4.4/series b/queue-4.4/series index 81d6829c903..8361a26d739 100644 --- a/queue-4.4/series +++ b/queue-4.4/series @@ -25,3 +25,4 @@ cfg80211-fix-memory-leak-of-wiphy-device-name.patch mac80211-drop-robust-management-frames-from-unknown-ta.patch perf-ui-helpline-use-strlcpy-as-a-shorter-form-of-strncpy-explicit-set-nul.patch perf-help-remove-needless-use-of-strncpy.patch +tcp-refine-memory-limit-test-in-tcp_fragment.patch diff --git a/queue-4.4/tcp-refine-memory-limit-test-in-tcp_fragment.patch b/queue-4.4/tcp-refine-memory-limit-test-in-tcp_fragment.patch new file mode 100644 index 00000000000..472cbeae126 --- /dev/null +++ b/queue-4.4/tcp-refine-memory-limit-test-in-tcp_fragment.patch @@ -0,0 +1,39 @@ +From b6653b3629e5b88202be3c9abc44713973f5c4b4 Mon Sep 17 00:00:00 2001 +From: Eric Dumazet +Date: Fri, 21 Jun 2019 06:09:55 -0700 +Subject: tcp: refine memory limit test in tcp_fragment() + +From: Eric Dumazet + +commit b6653b3629e5b88202be3c9abc44713973f5c4b4 upstream. + +tcp_fragment() might be called for skbs in the write queue. + +Memory limits might have been exceeded because tcp_sendmsg() only +checks limits at full skb (64KB) boundaries. + +Therefore, we need to make sure tcp_fragment() wont punish applications +that might have setup very low SO_SNDBUF values. + +Fixes: f070ef2ac667 ("tcp: tcp_fragment() should apply sane memory limits") +Signed-off-by: Eric Dumazet +Reported-by: Christoph Paasch +Tested-by: Christoph Paasch +Signed-off-by: David S. Miller +Signed-off-by: Greg Kroah-Hartman + +--- + net/ipv4/tcp_output.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +--- a/net/ipv4/tcp_output.c ++++ b/net/ipv4/tcp_output.c +@@ -1161,7 +1161,7 @@ int tcp_fragment(struct sock *sk, struct + if (nsize < 0) + nsize = 0; + +- if (unlikely((sk->sk_wmem_queued >> 1) > sk->sk_sndbuf)) { ++ if (unlikely((sk->sk_wmem_queued >> 1) > sk->sk_sndbuf + 0x20000)) { + NET_INC_STATS(sock_net(sk), LINUX_MIB_TCPWQUEUETOOBIG); + return -ENOMEM; + }