From: Victor Stinner <vstinner@python.org>
Date: Fri, 31 May 2024 14:06:10 +0000 (+0200)
Subject: gh-111201: Skip pyrepl Windows tests earlier (#119848)
X-Git-Tag: v3.14.0a1~1681
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=91601a55964fdb3c02b21fa3c8dc629daff2390f;p=thirdparty%2FPython%2Fcpython.git

gh-111201: Skip pyrepl Windows tests earlier (#119848)

Don't attempt to load pyrepl Windows console if platforms others than
Windows. For example, the import can fail if ctypes is missing.
---

diff --git a/Lib/test/test_pyrepl/test_windows_console.py b/Lib/test/test_pyrepl/test_windows_console.py
index 60392e231508..e52a54d31fb5 100644
--- a/Lib/test/test_pyrepl/test_windows_console.py
+++ b/Lib/test/test_pyrepl/test_windows_console.py
@@ -1,7 +1,11 @@
-import itertools
 import sys
 import unittest
 
+if sys.platform != 'win32':
+    raise unittest.SkipTest("test only relevant on win32")
+
+
+import itertools
 from functools import partial
 from typing import Iterable
 from unittest import TestCase
@@ -23,7 +27,6 @@ except ImportError:
     pass
 
 
-@unittest.skipIf(sys.platform != "win32", "Test class specifically for Windows")
 class WindowsConsoleTests(TestCase):
     def console(self, events, **kwargs) -> Console:
         console = WindowsConsole()