From: Hood Chatham <roberthoodchatham@gmail.com>
Date: Tue, 20 May 2025 18:41:14 +0000 (-0400)
Subject: gh-127146: xfail more Emscripten stack overflows (#134358)
X-Git-Tag: v3.15.0a1~1620
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=91e6a58e2d6fd23e886135457e28dfa980ec49ed;p=thirdparty%2FPython%2Fcpython.git

gh-127146: xfail more Emscripten stack overflows (#134358)

Adds some additional test xfails for Emscripten stack overflows. Also corrects a test skip for test_io.
---

diff --git a/Lib/test/test_builtin.py b/Lib/test/test_builtin.py
index 31597a320d41..f1f877c47a1e 100644
--- a/Lib/test/test_builtin.py
+++ b/Lib/test/test_builtin.py
@@ -1120,6 +1120,7 @@ class BuiltinTest(ComplexesAreIdenticalMixin, unittest.TestCase):
             self.check_iter_pickle(f1, list(f2), proto)
 
     @support.skip_wasi_stack_overflow()
+    @support.skip_emscripten_stack_overflow()
     @support.requires_resource('cpu')
     def test_filter_dealloc(self):
         # Tests recursive deallocation of nested filter objects using the
diff --git a/Lib/test/test_capi/test_misc.py b/Lib/test/test_capi/test_misc.py
index a597f23a992e..f74694a7a745 100644
--- a/Lib/test/test_capi/test_misc.py
+++ b/Lib/test/test_capi/test_misc.py
@@ -412,10 +412,12 @@ class CAPITest(unittest.TestCase):
             L = MyList((L,))
 
     @support.requires_resource('cpu')
+    @support.skip_emscripten_stack_overflow()
     def test_trashcan_python_class1(self):
         self.do_test_trashcan_python_class(list)
 
     @support.requires_resource('cpu')
+    @support.skip_emscripten_stack_overflow()
     def test_trashcan_python_class2(self):
         from _testcapi import MyList
         self.do_test_trashcan_python_class(MyList)
diff --git a/Lib/test/test_descr.py b/Lib/test/test_descr.py
index 76937432a430..14026531e223 100644
--- a/Lib/test/test_descr.py
+++ b/Lib/test/test_descr.py
@@ -4523,6 +4523,7 @@ class ClassPropertiesAndMethods(unittest.TestCase):
         del o
 
     @support.skip_wasi_stack_overflow()
+    @support.skip_emscripten_stack_overflow()
     @support.requires_resource('cpu')
     def test_wrapper_segfault(self):
         # SF 927248: deeply nested wrappers could cause stack overflow
diff --git a/Lib/test/test_exceptions.py b/Lib/test/test_exceptions.py
index d177e3dc0f50..cfd4a3e87695 100644
--- a/Lib/test/test_exceptions.py
+++ b/Lib/test/test_exceptions.py
@@ -1429,6 +1429,7 @@ class ExceptionTests(unittest.TestCase):
         self.assertIn("maximum recursion depth exceeded", str(exc))
 
     @support.skip_wasi_stack_overflow()
+    @support.skip_emscripten_stack_overflow()
     @cpython_only
     @support.requires_resource('cpu')
     def test_trashcan_recursion(self):
diff --git a/Lib/test/test_io.py b/Lib/test/test_io.py
index 5a8f1949baaa..90680c6d47ab 100644
--- a/Lib/test/test_io.py
+++ b/Lib/test/test_io.py
@@ -572,7 +572,7 @@ class IOTest(unittest.TestCase):
         for [test, abilities] in tests:
             with self.subTest(test):
                 if test == pipe_writer and not threading_helper.can_start_thread:
-                    skipTest()
+                    self.skipTest("Need threads")
                 with test() as obj:
                     do_test(test, obj, abilities)