From: Andreas Schneider <asn@samba.org>
Date: Fri, 3 Feb 2023 13:30:49 +0000 (+0100)
Subject: s3:smbd: Don't assign variable to itself
X-Git-Tag: talloc-2.4.1~1701
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=91e7351db396acda03d0c7f75e57a7285e62f118;p=thirdparty%2Fsamba.git

s3:smbd: Don't assign variable to itself

source3/smbd/msdfs.c:367:14: error: explicitly assigning value of variable of
    type 'char *' to itself [-Werror,-Wself-assign]
        servicename = servicename;
        ~~~~~~~~~~~ ^ ~~~~~~~~~~~

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
---

diff --git a/source3/smbd/msdfs.c b/source3/smbd/msdfs.c
index b5fd7608e07..6b99f3c1eb1 100644
--- a/source3/smbd/msdfs.c
+++ b/source3/smbd/msdfs.c
@@ -364,8 +364,6 @@ static NTSTATUS parse_dfs_path(TALLOC_CTX *ctx,
 		goto local_path;
 	}
 
-	servicename = servicename;
-
 	DBG_DEBUG("servicename: %s\n", servicename);
 
 	if(p == NULL) {