From: Ralph Boehme <slow@samba.org>
Date: Mon, 1 Feb 2021 11:03:08 +0000 (+0100)
Subject: smbd: remove a redundant fstat()in create_file_unixpath()
X-Git-Tag: tevent-0.11.0~1826
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=91edc50dc0aaa82d9ede7a7f8cf0f63312eb8503;p=thirdparty%2Fsamba.git

smbd: remove a redundant fstat()in create_file_unixpath()

openat_pathref_fsp() deep inside already calls fstat().

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
---

diff --git a/source3/smbd/open.c b/source3/smbd/open.c
index 68bc3ac4f8c..ca870c6a6b1 100644
--- a/source3/smbd/open.c
+++ b/source3/smbd/open.c
@@ -5745,14 +5745,6 @@ static NTSTATUS create_file_unixpath(connection_struct *conn,
 				goto fail;
 			}
 
-			ret = SMB_VFS_FSTAT(smb_fname_base->fsp,
-					    &smb_fname_base->st);
-			if (ret != 0) {
-				DBG_DEBUG("Unable to stat stream [%s]: %s\n",
-					  smb_fname_str_dbg(smb_fname_base),
-					  strerror(errno));
-			}
-
 			/*
 			 * https://bugzilla.samba.org/show_bug.cgi?id=10229
 			 * We need to check if the requested access mask