From: Richard Purdie <richard.purdie@linuxfoundation.org>
Date: Mon, 4 Jan 2016 17:32:45 +0000 (+0000)
Subject: cooker: Drop useless parsing exception
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=9241eb10847634e34c5ff8767ed8c114f66ff6cf;p=thirdparty%2Fopenembedded%2Fopenembedded-core-contrib.git

cooker: Drop useless parsing exception

The SyntaxError exception simply shows the recipe that failed to parse
which is pretty useless without the actual exception. We could make it
print more info, however we can just use one of the more generic handlers
instead and remove this one.

For a python indentation error, this leads to a much more readable error
message.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---

diff --git a/lib/bb/cooker.py b/lib/bb/cooker.py
index 4df88818fc4..5ceb198c056 100644
--- a/lib/bb/cooker.py
+++ b/lib/bb/cooker.py
@@ -2125,11 +2125,6 @@ class CookerParser(object):
             logger.error('ExpansionError during parsing %s: %s', value.recipe, str(exc))
             self.shutdown(clean=False)
             return False
-        except SyntaxError as exc:
-            self.error += 1
-            logger.error('Unable to parse %s', exc.recipe)
-            self.shutdown(clean=False)
-            return False
         except Exception as exc:
             self.error += 1
             etype, value, tb = sys.exc_info()