From: Benjamin Robin <dev@benjarobin.fr>
Date: Tue, 16 Feb 2021 22:18:28 +0000 (+0100)
Subject: basic: use -EINVAL for _MANAGED_OOM_PREFERENCE_INVALID
X-Git-Tag: v248-rc1~88^2~8
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=925484aacbf2c70db7fc2e7a89c80a8d02ccf3b8;p=thirdparty%2Fsystemd.git

basic: use -EINVAL for _MANAGED_OOM_PREFERENCE_INVALID

Follow-up of #11484
---

diff --git a/src/basic/cgroup-util.h b/src/basic/cgroup-util.h
index 420ddb59c0c..30b4819eb3d 100644
--- a/src/basic/cgroup-util.h
+++ b/src/basic/cgroup-util.h
@@ -297,7 +297,7 @@ typedef enum ManagedOOMPreference {
         MANAGED_OOM_PREFERENCE_AVOID = 1,
         MANAGED_OOM_PREFERENCE_OMIT = 2,
         _MANAGED_OOM_PREFERENCE_MAX,
-        _MANAGED_OOM_PREFERENCE_INVALID = -1
+        _MANAGED_OOM_PREFERENCE_INVALID = -EINVAL,
 } ManagedOOMPreference;
 
 const char* managed_oom_preference_to_string(ManagedOOMPreference a) _const_;
diff --git a/src/core/dbus-cgroup.c b/src/core/dbus-cgroup.c
index 2b8b833fe39..6652c212f19 100644
--- a/src/core/dbus-cgroup.c
+++ b/src/core/dbus-cgroup.c
@@ -1732,7 +1732,7 @@ int bus_cgroup_set_property(
 
                 p = managed_oom_preference_from_string(pref);
                 if (p < 0)
-                        return -EINVAL;
+                        return p;
 
                 if (!UNIT_WRITE_FLAGS_NOOP(flags)) {
                         c->moom_preference = p;