From: Christos Tsantilas <chtsanti@users.sourceforge.net>
Date: Tue, 5 Jan 2016 10:55:14 +0000 (+0200)
Subject: Ssl::CertValidationResponse::RecvdError::error_depth may used uninitialized
X-Git-Tag: SQUID_4_0_4~7
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=92862430bd1227d1eb2c6ef2507a3e6d5f686edc;p=thirdparty%2Fsquid.git

Ssl::CertValidationResponse::RecvdError::error_depth may used uninitialized

The Ssl::CertValidationResponse::RecvdError::error_depth is not initialized
inside copy constructor and inside "=" operator.

This class member added with the patch 14443:
    "%ssl::<cert_errors logformat code part2: provide depth information"

Detected by Coverity Scan. Issue 1346999
---

diff --git a/src/ssl/cert_validate_message.cc b/src/ssl/cert_validate_message.cc
index 8983b20a97..7c2249ed61 100644
--- a/src/ssl/cert_validate_message.cc
+++ b/src/ssl/cert_validate_message.cc
@@ -199,6 +199,7 @@ Ssl::CertValidationResponse::RecvdError::RecvdError(const RecvdError &old)
     id = old.id;
     error_no = old.error_no;
     error_reason = old.error_reason;
+    error_depth = old.error_depth;
     setCert(old.cert.get());
 }
 
@@ -207,6 +208,7 @@ Ssl::CertValidationResponse::RecvdError & Ssl::CertValidationResponse::RecvdErro
     id = old.id;
     error_no = old.error_no;
     error_reason = old.error_reason;
+    error_depth = old.error_depth;
     setCert(old.cert.get());
     return *this;
 }