From: Carson Radtke <carsonRadtke@users.noreply.github.com>
Date: Sun, 16 Jun 2024 17:51:52 +0000 (-0500)
Subject: gh-120568: fix file leak in PyUnstable_CopyPerfMapFile (#120569)
X-Git-Tag: v3.14.0a1~1473
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=92cebaa4911786683e87841bf7788351e7595ac2;p=thirdparty%2FPython%2Fcpython.git

gh-120568: fix file leak in PyUnstable_CopyPerfMapFile (#120569)
---

diff --git a/Python/sysmodule.c b/Python/sysmodule.c
index 00aa95531026..3bb7b4d59b94 100644
--- a/Python/sysmodule.c
+++ b/Python/sysmodule.c
@@ -2509,16 +2509,16 @@ PyAPI_FUNC(void) PyUnstable_PerfMapState_Fini(void) {
 
 PyAPI_FUNC(int) PyUnstable_CopyPerfMapFile(const char* parent_filename) {
 #ifndef MS_WINDOWS
-    FILE* from = fopen(parent_filename, "r");
-    if (!from) {
-        return -1;
-    }
     if (perf_map_state.perf_map == NULL) {
         int ret = PyUnstable_PerfMapState_Init();
         if (ret != 0) {
             return ret;
         }
     }
+    FILE* from = fopen(parent_filename, "r");
+    if (!from) {
+        return -1;
+    }
     char buf[4096];
     PyThread_acquire_lock(perf_map_state.map_lock, 1);
     int fflush_result = 0, result = 0;