From: Joseph Sutton <josephsutton@catalyst.net.nz>
Date: Thu, 30 Nov 2023 02:31:32 +0000 (+1300)
Subject: librpc:ndr: Don’t unnecessarily parenthesize macro arguments
X-Git-Tag: talloc-2.4.2~226
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=93379df97781efb03d5fea39e89efcbcaacc2eba;p=thirdparty%2Fsamba.git

librpc:ndr: Don’t unnecessarily parenthesize macro arguments

If we’re just passing a parameter to another macro which we know
correctly parenthesizes its arguments, then we don’t need to
parenthesize the parameter ourselves.

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
---

diff --git a/librpc/ndr/ndr_basic.c b/librpc/ndr/ndr_basic.c
index eae0fd062cb..fc8620f28c7 100644
--- a/librpc/ndr/ndr_basic.c
+++ b/librpc/ndr/ndr_basic.c
@@ -37,7 +37,7 @@
 	(int32_t)(NDR_BE(ndr) ? PULL_BE_U32(ndr->data,ofs) : PULL_LE_U32(ndr->data,ofs))
 
 #define NDR_PULL_I64(ndr, ofs) \
-	(NDR_BE(ndr) ? PULL_BE_I64((ndr)->data, (ofs)) : PULL_LE_I64((ndr)->data, (ofs)))
+	(NDR_BE(ndr) ? PULL_BE_I64((ndr)->data, ofs) : PULL_LE_I64((ndr)->data, ofs))
 
 #define NDR_PUSH_U16(ndr, ofs, v) \
 	do { \
@@ -69,9 +69,9 @@
 #define NDR_PUSH_I64(ndr, ofs, v) \
 	do { \
 		if (NDR_BE(ndr)) { \
-			PUSH_BE_I64((ndr)->data, (ofs), (v));	\
+			PUSH_BE_I64((ndr)->data, ofs, v);	\
 		} else { \
-			PUSH_LE_I64((ndr)->data, (ofs), (v));	\
+			PUSH_LE_I64((ndr)->data, ofs, v);	\
 		} \
 	} while (0)