From: Pauli <pauli@openssl.org>
Date: Thu, 21 Jul 2022 02:46:27 +0000 (+1000)
Subject: Coverity 1507376: Dereference after null check
X-Git-Tag: openssl-3.2.0-alpha1~2342
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=93429fc0ce9468242a463ff5878cd53b97e7f13f;p=thirdparty%2Fopenssl.git

Coverity 1507376: Dereference after null check

Reviewed-by: Hugo Landau <hlandau@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/18837)
---

diff --git a/crypto/sparse_array.c b/crypto/sparse_array.c
index 53e6e7d4607..bbbc9cdb369 100644
--- a/crypto/sparse_array.c
+++ b/crypto/sparse_array.c
@@ -109,8 +109,10 @@ static void sa_free_leaf(ossl_uintmax_t n, void *p, void *arg)
 
 void ossl_sa_free(OPENSSL_SA *sa)
 {
-    sa_doall(sa, &sa_free_node, NULL, NULL);
-    OPENSSL_free(sa);
+    if (sa != NULL) {
+        sa_doall(sa, &sa_free_node, NULL, NULL);
+        OPENSSL_free(sa);
+    }
 }
 
 void ossl_sa_free_leaves(OPENSSL_SA *sa)