From: Colin Ian King Date: Tue, 8 Jul 2025 14:26:04 +0000 (+0100) Subject: squashfs: fix incorrect argument to sizeof in kmalloc_array call X-Git-Tag: v6.16.1~168 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=937385eb9064f2e6352f43afccd061b6cf4fa2cc;p=thirdparty%2Fkernel%2Fstable.git squashfs: fix incorrect argument to sizeof in kmalloc_array call [ Upstream commit 97103dcec292b8688de142f7a48bd0d46038d3f6 ] The sizeof(void *) is the incorrect argument in the kmalloc_array call, it best to fix this by using sizeof(*cache_folios) instead. Fortunately the sizes of void* and folio* happen to be the same, so this has not shown up as a run time issue. [akpm@linux-foundation.org: fix build] Link: https://lkml.kernel.org/r/20250708142604.1891156-1-colin.i.king@gmail.com Fixes: 2e227ff5e272 ("squashfs: add optional full compressed block caching") Signed-off-by: Colin Ian King Cc: Phillip Lougher Cc: Chanho Min Signed-off-by: Andrew Morton Signed-off-by: Sasha Levin --- diff --git a/fs/squashfs/block.c b/fs/squashfs/block.c index 296c5a0fcc406..e7a4649fc85cf 100644 --- a/fs/squashfs/block.c +++ b/fs/squashfs/block.c @@ -89,7 +89,7 @@ static int squashfs_bio_read_cached(struct bio *fullbio, int err = 0; #ifdef CONFIG_SQUASHFS_COMP_CACHE_FULL struct folio **cache_folios = kmalloc_array(page_count, - sizeof(void *), GFP_KERNEL | __GFP_ZERO); + sizeof(*cache_folios), GFP_KERNEL | __GFP_ZERO); #endif bio_for_each_folio_all(fi, fullbio) {