From: Andrew Morton <akpm@linux-foundation.org>
Date: Tue, 2 Dec 2014 23:59:31 +0000 (-0800)
Subject: drivers/input/evdev.c: don't kfree() a vmalloc address
X-Git-Tag: v3.16.35~3392
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=93ecb50a3b40f0fc0dc16bd3ffa81c06be2d79a2;p=thirdparty%2Fkernel%2Fstable.git

drivers/input/evdev.c: don't kfree() a vmalloc address

commit 92788ac1eb06e69a822de45e2a8a63fa45eb5be2 upstream.

If kzalloc() failed and then evdev_open_device() fails, evdev_open()
will pass a vmalloc'ed pointer to kfree.

This might fix https://bugzilla.kernel.org/show_bug.cgi?id=88401, where
there was a crash in kfree().

Reported-by: Christian Casteyde <casteyde.christian@free.fr>
Belatedly-Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Henrik Rydberg <rydberg@euromail.se>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Luis Henriques <luis.henriques@canonical.com>
---

diff --git a/drivers/input/evdev.c b/drivers/input/evdev.c
index fd325ec9f064c..b51970d1e9ee1 100644
--- a/drivers/input/evdev.c
+++ b/drivers/input/evdev.c
@@ -422,7 +422,7 @@ static int evdev_open(struct inode *inode, struct file *file)
 
  err_free_client:
 	evdev_detach_client(evdev, client);
-	kfree(client);
+	kvfree(client);
 	return error;
 }