From: Jeremy Allison <jra@samba.org>
Date: Tue, 29 Sep 2020 03:03:08 +0000 (-0700)
Subject: s3: smbd: SMB1 reply_unlink() - the UCF_COND_ALLOW_WCARD_LCOMP makes no sense.
X-Git-Tag: talloc-2.3.2~421
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=93fcb44961c78c0850cf8815ad10e64336230d35;p=thirdparty%2Fsamba.git

s3: smbd: SMB1 reply_unlink() - the UCF_COND_ALLOW_WCARD_LCOMP makes no sense.

There's either a wildcard in the last component or not. Always use
UCF_ALWAYS_ALLOW_WCARD_LCOMP for calls that can take a wildcard.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
---

diff --git a/source3/smbd/reply.c b/source3/smbd/reply.c
index f10a92ec2ac..b651bf4a3d6 100644
--- a/source3/smbd/reply.c
+++ b/source3/smbd/reply.c
@@ -3609,7 +3609,7 @@ void reply_unlink(struct smb_request *req)
 	uint32_t dirtype;
 	NTSTATUS status;
 	bool path_contains_wcard = False;
-	uint32_t ucf_flags = UCF_COND_ALLOW_WCARD_LCOMP |
+	uint32_t ucf_flags = UCF_ALWAYS_ALLOW_WCARD_LCOMP |
 			ucf_flags_from_smb_request(req);
 	TALLOC_CTX *ctx = talloc_tos();