From: Ralph Boehme Date: Mon, 6 May 2019 12:07:53 +0000 (+0200) Subject: s3:mdssvv: don't fail the RPC request if the share name is unknown X-Git-Tag: tdb-1.4.2~206 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=940c3b31dd1fd68c9d7c9f4e9989d725dc77af4a;p=thirdparty%2Fsamba.git s3:mdssvv: don't fail the RPC request if the share name is unknown Taken from macOS. We have to return an empty share_path and an empty policy handle, but not fail the RPC request. Signed-off-by: Ralph Boehme Reviewed-by: Jeremy Allison --- diff --git a/selftest/knownfail.d/samba3.rpc b/selftest/knownfail.d/samba3.rpc index 8e13167b532..53c2c709ff8 100644 --- a/selftest/knownfail.d/samba3.rpc +++ b/selftest/knownfail.d/samba3.rpc @@ -1,4 +1,3 @@ -^samba3.rpc.mdssvc.rpccmd.open_unknown_share\(fileserver\) ^samba3.rpc.mdssvc.rpccmd.open_spotlight_disabled\(fileserver\) ^samba3.rpc.mdssvc.rpccmd.close\(fileserver\) ^samba3.rpc.mdssvc.rpccmd.null_ph\(fileserver\) diff --git a/source3/rpc_server/mdssvc/srv_mdssvc_nt.c b/source3/rpc_server/mdssvc/srv_mdssvc_nt.c index 49a26fac678..f40cfc3dd85 100644 --- a/source3/rpc_server/mdssvc/srv_mdssvc_nt.c +++ b/source3/rpc_server/mdssvc/srv_mdssvc_nt.c @@ -158,7 +158,6 @@ void _mdssvc_open(struct pipes_struct *p, struct mdssvc_open *r) snum = lp_servicenumber(r->in.share_name); if (!VALID_SNUM(snum)) { - p->fault_state = DCERPC_FAULT_CANT_PERFORM; return; }