From: Ralph Boehme <slow@samba.org>
Date: Tue, 27 Oct 2020 18:21:48 +0000 (+0100)
Subject: smbd: we DO NEED the low level fd
X-Git-Tag: samba-4.14.0rc1~336
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=945bdc7c2350ba2edc6fd40bfcf2d5ac3f451b5c;p=thirdparty%2Fsamba.git

smbd: we DO NEED the low level fd

In order to make everything handle based, we will need the basefile handle when
eg the client requests setting any of the filemetadata that is common across all
streams, eg the file's timestamps.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
---

diff --git a/source3/smbd/open.c b/source3/smbd/open.c
index 68621a892d9..47ee513e0a4 100644
--- a/source3/smbd/open.c
+++ b/source3/smbd/open.c
@@ -5629,8 +5629,6 @@ static NTSTATUS create_file_unixpath(connection_struct *conn,
 				   nt_errstr(status)));
 			goto fail;
 		}
-		/* we don't need the low level fd */
-		fd_close(base_fsp);
 	}
 
 	status = file_new(req, conn, &fsp);