From: Viktor Szakats Date: Wed, 18 Feb 2026 16:46:36 +0000 (+0100) Subject: libtests: drop two redundant `memset()`s X-Git-Tag: curl-8_19_0~177 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=947775a613f5e41e69a9a2baac7b79fc4e597544;p=thirdparty%2Fcurl.git libtests: drop two redundant `memset()`s Reported by clang-tidy `bugprone-sizeof-expression`. Silencing: ``` tests/libtest/cli_h2_pausing.c:164:23: warning: suspicious usage of 'sizeof()' on an expression of pointer type [bugprone-sizeof-expression] 164 | memset(&resolve, 0, sizeof(resolve)); | ^ tests/libtest/cli_upload_pausing.c:158:23: warning: suspicious usage of 'sizeof()' on an expression of pointer type [bugprone-sizeof-expression] 158 | memset(&resolve, 0, sizeof(resolve)); | ^ ``` Ref: https://clang.llvm.org/extra/clang-tidy/checks/bugprone/sizeof-expression.html Closes #20649 --- diff --git a/tests/libtest/cli_h2_pausing.c b/tests/libtest/cli_h2_pausing.c index b5b728ec20..ac57b5c5f8 100644 --- a/tests/libtest/cli_h2_pausing.c +++ b/tests/libtest/cli_h2_pausing.c @@ -161,7 +161,7 @@ static CURLcode test_cli_h2_pausing(const char *URL) result = (CURLcode)1; goto cleanup; } - memset(&resolve, 0, sizeof(resolve)); + curl_msnprintf(resolve_buf, sizeof(resolve_buf) - 1, "%s:%s:127.0.0.1", host, port); resolve = curl_slist_append(resolve, resolve_buf); diff --git a/tests/libtest/cli_upload_pausing.c b/tests/libtest/cli_upload_pausing.c index 64ae2898d5..c52117bf78 100644 --- a/tests/libtest/cli_upload_pausing.c +++ b/tests/libtest/cli_upload_pausing.c @@ -155,7 +155,7 @@ static CURLcode test_cli_upload_pausing(const char *URL) result = (CURLcode)1; goto cleanup; } - memset(&resolve, 0, sizeof(resolve)); + curl_msnprintf(resolve_buf, sizeof(resolve_buf) - 1, "%s:%s:127.0.0.1", host, port); resolve = curl_slist_append(resolve, resolve_buf);