From: Jeremy Kerr <jk@ozlabs.org>
Date: Thu, 16 Apr 2020 01:29:26 +0000 (+0800)
Subject: parser: prevent IntegrityErrors
X-Git-Tag: v3.0.0~49
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=947c6aae94b7b554ca701c1d7e5baf000759ed2d;p=thirdparty%2Fpatchwork.git

parser: prevent IntegrityErrors

Currently, the parser relies on causing (and catching) IntegrityErrors
on patch insert to catch duplicate (msgid,project) mails.

This change performs an atomic select -> insert instead.

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Signed-off-by: Stephen Finucane <stephen@that.guru>
[stephenfin: Remove 'expectedFailure' marker again]
---

diff --git a/patchwork/parser.py b/patchwork/parser.py
index dce03a4f..021c034e 100644
--- a/patchwork/parser.py
+++ b/patchwork/parser.py
@@ -1069,7 +1069,10 @@ def parse_mail(mail, list_id=None):
             filenames = find_filenames(diff)
             delegate = find_delegate_by_filename(project, filenames)
 
-        try:
+        with transaction.atomic():
+            if Patch.objects.filter(project=project, msgid=msgid):
+                raise DuplicateMailError(msgid=msgid)
+
             patch = Patch.objects.create(
                 msgid=msgid,
                 project=project,
@@ -1084,8 +1087,6 @@ def parse_mail(mail, list_id=None):
                 delegate=delegate,
                 state=find_state(mail))
             logger.debug('Patch saved')
-        except IntegrityError:
-            raise DuplicateMailError(msgid=msgid)
 
         for attempt in range(1, 11):  # arbitrary retry count
             try:
diff --git a/patchwork/tests/test_parser.py b/patchwork/tests/test_parser.py
index 0122fb8c..b640a3a1 100644
--- a/patchwork/tests/test_parser.py
+++ b/patchwork/tests/test_parser.py
@@ -1138,7 +1138,6 @@ class DuplicateMailTest(TestCase):
 
         self.assertEqual(errors, [])
 
-    @unittest.expectedFailure
     def test_duplicate_patch(self):
         diff = read_patch('0001-add-line.patch')
         m = create_email(diff, listid=self.listid, msgid='1@example.com')