From: Spencer E. Olson Date: Tue, 12 Jan 2016 17:33:18 +0000 (-0700) Subject: staging: comedi: ni_tiocmd: change mistaken use of start_src for start_arg X-Git-Tag: v3.16.35~219 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=94d378368fe2ea724b2a1b3a053551680fedf423;p=thirdparty%2Fkernel%2Fstable.git staging: comedi: ni_tiocmd: change mistaken use of start_src for start_arg commit 1fd24a4702d2af0ea4d5845126cf57d4d1796216 upstream. This fixes a bug in function ni_tio_input_inttrig(). The trigger number should be compared to cmd->start_arg, not cmd->start_src. Fixes: 6a760394d7eb ("staging: comedi: ni_tiocmd: clarify the cmd->start_arg validation and use") Signed-off-by: Spencer E. Olson Reviewed-by: Ian Abbott Signed-off-by: Greg Kroah-Hartman Cc: Ian Abbott Signed-off-by: Luis Henriques --- diff --git a/drivers/staging/comedi/drivers/ni_tiocmd.c b/drivers/staging/comedi/drivers/ni_tiocmd.c index 2557ab48cb6ca..db4dc1410342a 100644 --- a/drivers/staging/comedi/drivers/ni_tiocmd.c +++ b/drivers/staging/comedi/drivers/ni_tiocmd.c @@ -98,7 +98,7 @@ static int ni_tio_input_inttrig(struct comedi_device *dev, BUG_ON(counter == NULL); - if (trig_num != cmd->start_src) + if (trig_num != cmd->start_arg) return -EINVAL; spin_lock_irqsave(&counter->lock, flags);