From: Derek Brown <derek@allderek.com>
Date: Tue, 7 Jan 2020 16:40:23 +0000 (-0800)
Subject: bpo-39198: Ensure logging global lock is released on exception in isEnabledFor (GH... 
X-Git-Tag: v3.9.0a3~125
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=950c6795aa0ffa85e103a13e7a04e08cb34c66ad;p=thirdparty%2FPython%2Fcpython.git

bpo-39198: Ensure logging global lock is released on exception in isEnabledFor (GH-17689)
---

diff --git a/Lib/logging/__init__.py b/Lib/logging/__init__.py
index 62a87a71b1a3..59d5fa5b64d2 100644
--- a/Lib/logging/__init__.py
+++ b/Lib/logging/__init__.py
@@ -1687,12 +1687,15 @@ class Logger(Filterer):
             return self._cache[level]
         except KeyError:
             _acquireLock()
-            if self.manager.disable >= level:
-                is_enabled = self._cache[level] = False
-            else:
-                is_enabled = self._cache[level] = level >= self.getEffectiveLevel()
-            _releaseLock()
-
+            try:
+                if self.manager.disable >= level:
+                    is_enabled = self._cache[level] = False
+                else:
+                    is_enabled = self._cache[level] = (
+                        level >= self.getEffectiveLevel()
+                    )
+            finally:
+                _releaseLock()
             return is_enabled
 
     def getChild(self, suffix):
diff --git a/Misc/NEWS.d/next/Library/2020-01-02-20-21-03.bpo-39198.nzwGyG.rst b/Misc/NEWS.d/next/Library/2020-01-02-20-21-03.bpo-39198.nzwGyG.rst
new file mode 100644
index 000000000000..ec4e81e2bbe4
--- /dev/null
+++ b/Misc/NEWS.d/next/Library/2020-01-02-20-21-03.bpo-39198.nzwGyG.rst
@@ -0,0 +1 @@
+If an exception were to be thrown in `Logger.isEnabledFor` (say, by asyncio timeouts or stopit) , the `logging` global lock may not be released appropriately, resulting in deadlock.  This change wraps that block of code with `try...finally` to ensure the lock is released.
\ No newline at end of file