From: Ralph Boehme <slow@samba.org>
Date: Wed, 29 Apr 2020 09:06:26 +0000 (+0200)
Subject: smbd: remove unneeded parent_dir variable from mkdir_internal()
X-Git-Tag: ldb-2.2.0~808
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=954d877a2eefd985479f35a99c2dd8c804f15cc0;p=thirdparty%2Fsamba.git

smbd: remove unneeded parent_dir variable from mkdir_internal()

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed Apr 29 18:16:02 UTC 2020 on sn-devel-184
---

diff --git a/source3/smbd/open.c b/source3/smbd/open.c
index 03505cab42c..ef20b44ea15 100644
--- a/source3/smbd/open.c
+++ b/source3/smbd/open.c
@@ -4043,7 +4043,6 @@ static NTSTATUS mkdir_internal(connection_struct *conn,
 		loadparm_s3_global_substitution();
 	mode_t mode;
 	struct smb_filename *parent_dir_fname = NULL;
-	char *parent_dir = NULL;
 	NTSTATUS status;
 	bool posix_open = false;
 	bool need_re_stat = false;
@@ -4064,7 +4063,6 @@ static NTSTATUS mkdir_internal(connection_struct *conn,
 	if (!ok) {
 		return NT_STATUS_NO_MEMORY;
 	}
-	parent_dir = parent_dir_fname->base_name;
 
 	if (file_attributes & FILE_FLAG_POSIX_SEMANTICS) {
 		posix_open = true;
@@ -4082,7 +4080,7 @@ static NTSTATUS mkdir_internal(connection_struct *conn,
 	if(!NT_STATUS_IS_OK(status)) {
 		DEBUG(5,("mkdir_internal: check_parent_access "
 			"on directory %s for path %s returned %s\n",
-			parent_dir,
+			smb_fname_str_dbg(parent_dir_fname),
 			smb_dname->base_name,
 			nt_errstr(status) ));
 		return status;