From: Luca Bruno <lethalman88@gmail.com>
Date: Wed, 2 Jun 2010 09:11:03 +0000 (+0200)
Subject: Do not support assigning to `this'
X-Git-Tag: 0.9.2~4
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=95b2e15a05fdd6ffa2a75654f06932378cd8ebbb;p=thirdparty%2Fvala.git

Do not support assigning to `this'

Fixes bug 620120.
---

diff --git a/vala/valaassignment.vala b/vala/valaassignment.vala
index 5833e6be4..575ff966f 100644
--- a/vala/valaassignment.vala
+++ b/vala/valaassignment.vala
@@ -145,7 +145,8 @@ public class Vala.Assignment : Expression {
 		if (left is MemberAccess) {
 			var ma = (MemberAccess) left;
 
-			if (!(ma.symbol_reference is Signal || ma.symbol_reference is DynamicProperty) && ma.value_type == null) {
+			if ((!(ma.symbol_reference is Signal || ma.symbol_reference is DynamicProperty) && ma.value_type == null) ||
+			    (ma.inner == null && ma.member_name == "this" && analyzer.is_in_instance_method ())) {
 				error = true;
 				Report.error (source_reference, "unsupported lvalue in assignment");
 				return false;