From: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Date: Thu, 2 May 2019 23:29:37 +0000 (+1200)
Subject: s4/rpc/drsuapi/writespn: check the actual error code (CID 1034691)
X-Git-Tag: tdb-1.4.1~138
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=95d7e939c58620bb8af9926cf607d06a78ee6d39;p=thirdparty%2Fsamba.git

s4/rpc/drsuapi/writespn: check the actual error code (CID 1034691)

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
---

diff --git a/source4/rpc_server/drsuapi/writespn.c b/source4/rpc_server/drsuapi/writespn.c
index 9a289897f3e..c6faea39e9f 100644
--- a/source4/rpc_server/drsuapi/writespn.c
+++ b/source4/rpc_server/drsuapi/writespn.c
@@ -111,8 +111,8 @@ static bool writespn_check_spn(struct drsuapi_bind_state *b_state,
 		return false;
 	}
 
-	ret = krb5_parse_name_flags(krb_ctx, spn, KRB5_PRINCIPAL_PARSE_NO_REALM,
-				    &principal);
+	kerr = krb5_parse_name_flags(krb_ctx, spn, KRB5_PRINCIPAL_PARSE_NO_REALM,
+				     &principal);
 	if (kerr != 0) {
 		krb5_free_context(krb_ctx);
 		talloc_free(tmp_ctx);