From: Andrew Tridgell <tridge@samba.org>
Date: Mon, 14 Feb 2011 02:08:44 +0000 (+1100)
Subject: s4-ldb: fixed a uninitialised el->flags in ldb_tdb
X-Git-Tag: tevent-0.9.11~682
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=95e347a2d05d3b2c01655e02fd9eb0f5e4659ec1;p=thirdparty%2Fsamba.git

s4-ldb: fixed a uninitialised el->flags in ldb_tdb

this caused an intermittent failure in some tests

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
---

diff --git a/source4/lib/ldb/ldb_tdb/ldb_tdb.c b/source4/lib/ldb/ldb_tdb/ldb_tdb.c
index 831361c5473..2f7f2220860 100644
--- a/source4/lib/ldb/ldb_tdb/ldb_tdb.c
+++ b/source4/lib/ldb/ldb_tdb/ldb_tdb.c
@@ -705,8 +705,7 @@ int ltdb_modify_internal(struct ldb_module *module,
 					ret = LDB_ERR_OTHER;
 					goto done;
 				}
-				el->name = msg->elements[i].name;
-				el->num_values = msg->elements[i].num_values;
+				*el = msg->elements[i];
 				el->values = talloc_array(el, struct ldb_val, el->num_values);
 				if (el->values == NULL) {
 					ret = LDB_ERR_OTHER;