From: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Date: Thu, 27 Jun 2019 04:57:20 +0000 (+1200)
Subject: script/compare_cc_results: print usage on too few args
X-Git-Tag: samba-4.11.0rc1~89
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=96148436b7f8633da920ef5b52d8ad3aa735a9cc;p=thirdparty%2Fsamba.git

script/compare_cc_results: print usage on too few args

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
---

diff --git a/script/compare_cc_results.py b/script/compare_cc_results.py
index 4b8abf601f4..cc16751cf6e 100755
--- a/script/compare_cc_results.py
+++ b/script/compare_cc_results.py
@@ -1,9 +1,11 @@
 #!/usr/bin/env python3
+"""Compare the results of native and cross-compiled configure tests
 
-#
-# Compare the results of native and cross-compiled configure tests
-#
+The compared files are called "default.cache.py" and are generated in
+bin/c4che/.
 
+USAGE: compare_cc_results.py CONFIG_1 CONFIG_2 [CONFIG_3 [CONFIG_4 ...]]
+"""
 from __future__ import print_function
 import sys
 import difflib
@@ -19,6 +21,10 @@ exceptions = [
     'LIBRESOLV_WRAPPER_SO_PATH',
 ]
 
+if len(sys.argv) < 3:
+    print(__doc__)
+    sys.exit(1)
+
 base_lines = list()
 base_fname = ''
 
diff --git a/selftest/knownfail.d/usage b/selftest/knownfail.d/usage
index 731eb89e671..6aba087dd22 100644
--- a/selftest/knownfail.d/usage
+++ b/selftest/knownfail.d/usage
@@ -1,5 +1,4 @@
 samba.tests.usage.samba.tests.usage.PythonScriptUsageTests.test_chgtdcpass.none.
-samba.tests.usage.samba.tests.usage.PythonScriptUsageTests.test_compare_cc_results_py.none.
 samba.tests.usage.samba.tests.usage.PythonScriptUsageTests.test_demodirsync_py.none.
 samba.tests.usage.samba.tests.usage.PythonScriptUsageTests.test_findprovisionusnranges.none.
 samba.tests.usage.samba.tests.usage.PythonScriptUsageTests.test_get_descriptors.none.