From: Michal Nowak <mnowak@isc.org>
Date: Fri, 28 Apr 2023 08:24:17 +0000 (+0200)
Subject: Add a friendly Danger plea to run the pairwise CI job
X-Git-Tag: v9.19.14~37^2
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=96563c6020a8a95442145408c299806f26a9055a;p=thirdparty%2Fbind9.git

Add a friendly Danger plea to run the pairwise CI job

Sometimes a pairwise definition for a new ./configure switch is added
but not tested in the CI.
---

diff --git a/dangerfile.py b/dangerfile.py
index 925d0a42146..41cecb079a2 100644
--- a/dangerfile.py
+++ b/dangerfile.py
@@ -398,11 +398,19 @@ switches_added = lines_containing(
     configure_added_lines, "AC_ARG_ENABLE"
 ) + lines_containing(configure_added_lines, "AC_ARG_WITH")
 annotations_added = lines_containing(configure_added_lines, "# [pairwise: ")
-if len(switches_added) > len(annotations_added):
-    fail(
-        "This merge request adds at least one new `./configure` switch that "
-        "is not annotated for pairwise testing purposes."
-    )
+if switches_added:
+    if len(switches_added) > len(annotations_added):
+        fail(
+            "This merge request adds at least one new `./configure` switch that "
+            "is not annotated for pairwise testing purposes."
+        )
+    else:
+        message(
+            "**Before merging**, please start a full CI pipeline for this "
+            "branch with the `PAIRWISE_TESTING` variable set to any "
+            "non-empty value (e.g. `1`). This will cause the `pairwise` "
+            "job to exercise the new `./configure` switches."
+        )
 
 ###############################################################################
 # USER-VISIBLE LOG LEVELS