From: Dan Carpenter <dan.carpenter@linaro.org>
Date: Wed, 6 Aug 2025 11:46:12 +0000 (+0300)
Subject: tty: sysrq: delete unnecessary check
X-Git-Tag: v6.18-rc1~77^2~43
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=96c08ff80b8fce45e49fee5eba4b40b1654eb5aa;p=thirdparty%2Fkernel%2Flinux.git

tty: sysrq: delete unnecessary check

This code checks if (write) is true twice in a row.  It's more
readable to delete the first check.

Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Jiri Slaby <jirislaby@kernel.org>
Link: https://lore.kernel.org/r/aJNAhHtKkhWjosDV@stanley.mountain
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

diff --git a/drivers/tty/sysrq.c b/drivers/tty/sysrq.c
index 97f8a9a522856..1f78b0db3b259 100644
--- a/drivers/tty/sysrq.c
+++ b/drivers/tty/sysrq.c
@@ -1133,8 +1133,7 @@ static int sysrq_sysctl_handler(const struct ctl_table *table, int write,
 	 * Behaves like do_proc_dointvec as t does not have min nor max.
 	 */
 	ret = proc_dointvec_minmax(&t, write, buffer, lenp, ppos);
-
-	if (ret || !write)
+	if (ret)
 		return ret;
 
 	if (write)