From: Timo Sirainen <timo.sirainen@open-xchange.com>
Date: Wed, 7 Jun 2023 09:35:59 +0000 (+0300)
Subject: lib-ssl-iostream: Don't try to load ssl_iostream_openssl module twice
X-Git-Tag: 2.4.1~1566
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=971be8a091b7f0764090f348e2ab832bb56df662;p=thirdparty%2Fdovecot%2Fcore.git

lib-ssl-iostream: Don't try to load ssl_iostream_openssl module twice

Error handling was also not working as expected, because the first load
attempt already called i_fatal()

Forgotten in fe4058e6f01bf0e104c44815b6df7cfefb80634c
---

diff --git a/src/lib-ssl-iostream/iostream-ssl.c b/src/lib-ssl-iostream/iostream-ssl.c
index 249c9ff1e8..bb4f0277c4 100644
--- a/src/lib-ssl-iostream/iostream-ssl.c
+++ b/src/lib-ssl-iostream/iostream-ssl.c
@@ -49,7 +49,6 @@ int ssl_module_load(const char **error_r)
 	mod_set.abi_version = DOVECOT_ABI_VERSION;
 	mod_set.setting_name = "<built-in lib-ssl-iostream lookup>";
 	mod_set.require_init_funcs = TRUE;
-	ssl_module = module_dir_load(MODULE_DIR, plugin_name, &mod_set);
 	if (module_dir_try_load_missing(&ssl_module, MODULE_DIR, plugin_name,
 					&mod_set, error_r) < 0)
 		return -1;