From: Volker Lendecke <vl@samba.org>
Date: Tue, 2 Aug 2022 11:08:43 +0000 (+0200)
Subject: smbd: Fix a "set but not used" warning
X-Git-Tag: samba-4.17.0rc1~69
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=972dd999b8d67f22434db83492d9ccc2efe06300;p=thirdparty%2Fsamba.git

smbd: Fix a "set but not used" warning

This is copy&paste from reply_negprot() where this variable was used
to set the remote architecture. This isn't used anymore in the
stripped down smb2 version of this.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Thu Aug  4 21:46:23 UTC 2022 on sn-devel-184
---

diff --git a/source3/smbd/smb2_negprot.c b/source3/smbd/smb2_negprot.c
index da567951c0b..baddbecaade 100644
--- a/source3/smbd/smb2_negprot.c
+++ b/source3/smbd/smb2_negprot.c
@@ -1053,7 +1053,6 @@ NTSTATUS smb2_multi_protocol_reply_negprot(struct smb_request *req)
 	bool choice_set = false;
 	int protocol;
 	const char *p;
-	int protocols = 0;
 	int num_cliprotos;
 	char **cliprotos;
 	size_t i;
@@ -1117,14 +1116,6 @@ NTSTATUS smb2_multi_protocol_reply_negprot(struct smb_request *req)
 		p += strlen(p) + 2;
 	}
 
-	for (i=0; i<num_cliprotos; i++) {
-		if (strcsequal(cliprotos[i], "SMB 2.002")) {
-			protocols |= PROT_SMB_2_002;
-		} else if (strcsequal(cliprotos[i], "SMB 2.???")) {
-			protocols |= PROT_SMB_2_FF;
-		}
-	}
-
 	/* possibly reload - change of architecture */
 	reload_services(sconn, conn_snum_used, true);